Click here to Skip to main content
15,512,053 members

Welcome to the Lounge

   

For discussing anything related to a software developer's life but is not for programming questions. Got a programming question?

The Lounge is rated Safe For Work. If you're about to post something inappropriate for a shared office environment, then don't post it. No ads, no abuse, and no programming questions. Trolling, (political, climate, religious or whatever) will result in your account being removed.

 
GeneralRe: Is the Code Review Parallel Programming or Singleton? Pin
Henry Minute21-Jun-11 5:13
Henry Minute21-Jun-11 5:13 
AnswerRe: Is the Code Review Parallel Programming or Singleton? Pin
Jörgen Sigvardsson20-Jun-11 13:03
Jörgen Sigvardsson20-Jun-11 13:03 
AnswerRe: Is the Code Review Parallel Programming or Singleton? Pin
_Maxxx_20-Jun-11 13:39
professional_Maxxx_20-Jun-11 13:39 
AnswerRe: Is the Code Review Parallel Programming or Singleton? Pin
Mark_Wallace20-Jun-11 21:22
Mark_Wallace20-Jun-11 21:22 
GeneralRe: Is the Code Review Parallel Programming or Singleton? Pin
bit_cmdr21-Jun-11 6:58
bit_cmdr21-Jun-11 6:58 
GeneralRe: Is the Code Review Parallel Programming or Singleton? Pin
Mark_Wallace21-Jun-11 21:14
Mark_Wallace21-Jun-11 21:14 
AnswerRe: Is the Code Review Parallel Programming or Singleton? Pin
tom144322-Jun-11 4:59
tom144322-Jun-11 4:59 
AnswerRe: Is the Code Review Parallel Programming or Singleton? Pin
Carl_Sharman22-Jun-11 6:05
Carl_Sharman22-Jun-11 6:05 
The biggest challenge I've found with code reviews is people actually doing them long term. They'll run for a while, everybody will congratulate themselves on how useful they are, then at some people will stop doing it.

And when people stop doing it, it's always for the same reason "We don't have time". This is partially true, but also hides the biggest reason, IMO: "We can't be bothered".

Anybody that's ever done code reviews knows how much value they have, but the trouble is they can be time-consuming, tiresome, hardwork and boring. With that in mind, I'd recommend the following:

1. Don't have dedicated reviewers, because they will get bored quicker. Let everybody get involved; share the pain around.
2. Keep the reviews short and sweet. Split large reviews into multiple sessions.
3. Don't review in more detail than you really need.
4. Make sure everybody understand the benefits and are sold on the idea before you start.
5. Don't worry too much if you have a really busy period and fall behind on the reviews. Just let them go; draw a line in the sand and start again.

Having said that, if you do have a senior dev that just loves doing code reviews and is happy to do them all, you might well be able to ignore all of the above. Just seems unlikely!

Happy reviewing,

Carl
AnswerRe: Is the Code Review Parallel Programming or Singleton? Pin
Dave_622-Jun-11 6:27
Dave_622-Jun-11 6:27 
AnswerRe: Is the Code Review Parallel Programming or Singleton? Pin
Toto110722-Jun-11 7:59
professionalToto110722-Jun-11 7:59 
AnswerRe: Is the Code Review Parallel Programming or Singleton? Pin
jschell22-Jun-11 10:09
jschell22-Jun-11 10:09 
AnswerRe: Is the Code Review Parallel Programming or Singleton? Pin
Member 440945722-Jun-11 20:14
Member 440945722-Jun-11 20:14 
GeneralWhat the ....!? Pin
Albert Holguin20-Jun-11 10:26
professionalAlbert Holguin20-Jun-11 10:26 
GeneralRe: What the ....!? Pin
#realJSOP20-Jun-11 10:40
mva#realJSOP20-Jun-11 10:40 
GeneralRe: What the ....!? Pin
Henry Minute20-Jun-11 10:44
Henry Minute20-Jun-11 10:44 
GeneralRe: What the ....!? Pin
Tom Delany20-Jun-11 12:55
Tom Delany20-Jun-11 12:55 
GeneralRe: What the ....!? Pin
Henry Minute21-Jun-11 0:56
Henry Minute21-Jun-11 0:56 
GeneralRe: What the ....!? Pin
Tom Delany21-Jun-11 15:58
Tom Delany21-Jun-11 15:58 
GeneralRe: What the ....!? Pin
S Houghtelin20-Jun-11 10:46
professionalS Houghtelin20-Jun-11 10:46 
GeneralRe: What the ....!? Pin
Albert Holguin20-Jun-11 10:54
professionalAlbert Holguin20-Jun-11 10:54 
GeneralRe: What the ....!? Pin
Rajesh R Subramanian20-Jun-11 10:47
professionalRajesh R Subramanian20-Jun-11 10:47 
GeneralRe: What the ....!? Pin
Albert Holguin20-Jun-11 10:51
professionalAlbert Holguin20-Jun-11 10:51 
JokeRe: What the ....!? Pin
S Houghtelin20-Jun-11 10:54
professionalS Houghtelin20-Jun-11 10:54 
GeneralRe: What the ....!? Pin
Albert Holguin20-Jun-11 10:56
professionalAlbert Holguin20-Jun-11 10:56 
GeneralRe: What the ....!? Pin
GenJerDan20-Jun-11 11:56
GenJerDan20-Jun-11 11:56 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.


Straw Poll

An amazing AI programming tool is invented that can do one task perfectly. What would you choose?
  Results   609 votes