Click here to Skip to main content
15,501,747 members

Welcome to the Lounge

   

For discussing anything related to a software developer's life but is not for programming questions. Got a programming question?

The Lounge is rated Safe For Work. If you're about to post something inappropriate for a shared office environment, then don't post it. No ads, no abuse, and no programming questions. Trolling, (political, climate, religious or whatever) will result in your account being removed.

 
GeneralRe: Dealing with bad-code Pin
Kirk Wood10-May-13 6:00
MemberKirk Wood10-May-13 6:00 
GeneralRe: Dealing with bad-code Pin
dbrenth10-May-13 4:39
Memberdbrenth10-May-13 4:39 
GeneralRe: Dealing with bad-code Pin
User 483504710-May-13 4:41
MemberUser 483504710-May-13 4:41 
GeneralRe: Dealing with bad-code Pin
Member 1003786210-May-13 5:03
professionalMember 1003786210-May-13 5:03 
GeneralRe: Dealing with bad-code Pin
Alan Balkany10-May-13 5:34
MemberAlan Balkany10-May-13 5:34 
GeneralRe: Dealing with bad-code Pin
RafagaX10-May-13 6:16
professionalRafagaX10-May-13 6:16 
GeneralRe: Dealing with bad-code Pin
SeattleC++10-May-13 7:03
MemberSeattleC++10-May-13 7:03 
GeneralRe: Dealing with bad-code Pin
Carl_Sharman10-May-13 8:12
MemberCarl_Sharman10-May-13 8:12 
I've been your team. The situation wasn't exactly the same, but it may help you to see their point of view.

A few years ago I and others had worked hard at creating a system that was just about doing it's job. However, the main page was big and slow. We had used too many 3rd party libraries. It worked, but only just.

Then we had some young wizz-kid join the team, who started loudly proclaiming that this page needed to be re-written. I resisted. I shrugged off his concerns as over-dramatic, and consoled myself with weak arguments like "browsers will improve", and "hardware will get faster". It wasn't enough though; the page just got worse as more features were added to it.

Eventually it got so bad that we gave in. We gave our young upstart his head and let him lead on a replacement. I worked closely with him, and in the end I learnt more from that kid in 6 months than I'd learned in the last 3 years. We created a fantastic replacement that we were all really proud of, that performs really fast and is really nice to use. I've used the knowledge I learned on that project to great effect on many projects since.

Why did we resist so long? Well, we'd put a lot of work into the old code and didn't want to see it wasted. We didn't want to admit that a young interloper actually knew better than us old lags. More than anything, doing the work the first time around was painful, and we perceived that doing it all over again would be just as painful. As it turned out the reality was anything but; re-writing was a joy, and we were all very glad we bit the bullet.

So how does this help you? Well it probably doesn't much. It's unlikely that you telling them their code is bad will motivate them to want to change. For us, we changed because it got to the point where the pain of inaction outweighed the pain of changing.

What you could try is to sell the benefits of a re-write to them, and re-assure them that the change won't be as painful as they probably think it will.

All the best.
GeneralRe: Dealing with bad-code Pin
Nucleotic10-May-13 13:36
MemberNucleotic10-May-13 13:36 
GeneralThis is never going to work. Pin
Nagy Vilmos9-May-13 1:28
professionalNagy Vilmos9-May-13 1:28 
GeneralRe: This is never going to work. Pin
Keith Barrow9-May-13 1:33
professionalKeith Barrow9-May-13 1:33 
GeneralRe: This is never going to work. Pin
Nagy Vilmos9-May-13 1:35
professionalNagy Vilmos9-May-13 1:35 
GeneralIT IS going to work. Pin
Guirec9-May-13 1:43
professionalGuirec9-May-13 1:43 
GeneralRe: IT IS going to work. Pin
Nagy Vilmos9-May-13 2:12
professionalNagy Vilmos9-May-13 2:12 
GeneralRe: This is never going to work. Pin
OriginalGriff9-May-13 1:45
mveOriginalGriff9-May-13 1:45 
GeneralRe: This is never going to work. Pin
Nagy Vilmos9-May-13 2:08
professionalNagy Vilmos9-May-13 2:08 
GeneralRe: This is never going to work. Pin
OriginalGriff9-May-13 2:09
mveOriginalGriff9-May-13 2:09 
GeneralRe: This is never going to work. Pin
Alan Burkhart10-May-13 3:33
MemberAlan Burkhart10-May-13 3:33 
GeneralRe: This is never going to work. Pin
Eddy Vluggen9-May-13 2:19
professionalEddy Vluggen9-May-13 2:19 
GeneralRe: This is never going to work. Pin
Argonia9-May-13 2:49
professionalArgonia9-May-13 2:49 
GeneralRe: This is never going to work. Pin
Roger Wright9-May-13 8:58
professionalRoger Wright9-May-13 8:58 
GeneralRe: This is never going to work. Pin
PB 369,7839-May-13 2:17
MemberPB 369,7839-May-13 2:17 
GeneralRe: This is never going to work. Pin
Nagy Vilmos9-May-13 2:34
professionalNagy Vilmos9-May-13 2:34 
GeneralRe: This is never going to work. Pin
Joezer BH9-May-13 4:01
professionalJoezer BH9-May-13 4:01 
GeneralRe: This is never going to work. Pin
Nagy Vilmos9-May-13 4:21
professionalNagy Vilmos9-May-13 4:21 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.


Straw Poll

How would you describe your current job?
Fighting dragons everyday or clicking the same boxes on the same forms, day after day?
  Results   276 votes