|Background - old(ish) grumpy git who worked in UK Financial Services for far too long. Bolshie, argumentative, pretty good at what I did, didn't entirely trust my peer group.
Scenario - "forced" into "SDLC" (yeah, they named their internal process that )... we all knew what it should be, shame the committee defining the (compulsory) process didn't. It was a disaster waiting to happen, oops, it didn't wait, it happened.
Opportunity - "Volunteers required for training on Peer Review (and how to do it properly)". Me - I'll go for that ... in the back of my mind was sarcasm, mickey-take, etc.
Fact - Training was bl***y good - Takeaway from that = make sure the training is good.
Me - actually this can work, I need to evangelize (exaggerating only a little) ... Takeaway = if the training is good, the grumpy git will get the rest on board
It's not about blame, putting people down, nit-picking. Ok, not "ONE THING" ... rethink ..
eschindler wrote:What one thing, ONE THING, do you wish the boss (or powers that be) understood about code review?
Chill60 says:It's not there to find faults, it's there to add QUALITY
I guess because in my experiences of the "powers that be", it always boils down to someone (else) to blame instead of focussing on making the process better.
eschindler wrote:Why did you choose THAT as the one thing to wish for?
The thing I absolutely LOVED about the training process was the insistence that it needed to be completely objective. There were processes put in place to ensure that objectiveness... including timed meetings. All designed to stop anyone being put on the defensive to be honest. I was told at one point to print out the "document" I was reviewing (it's not just about code) and go "find a palm tree". Ok, it was a spindly little tree next to the smoking shelter, but it worked - get away from distractions (Or ... treat the review with respect!)
Feel free to include a link to this post (I did say I was a bolshie, grumpy, old git!)
eschindler wrote:Nobody is being quoted here.
If you need more, just let me know. Can't mention any company names obviously.
Or you could quote me as a "convert to code review"