Re: newbie using a game to learn c# and object-oriented programming Could I make an abstract factory to merge the other factories in a game? - C# Discussion Boards

Re: WMI Connection to Remote PC with ManegementScope too slow(8-10 seconds). The WMI Query itself is OK (under 1 second)

Gerry Schmitz26-Dec-21 3:13

Gerry Schmitz

26-Dec-21 3:13

Pre-load it 10 seconds before you need it.

"Before entering on an understanding, I have meditated for a long time, and have foreseen what might happen. It is not genius which reveals to me suddenly, secretly, what I have to say or to do in a circumstance unexpected by other people; it is reflection, it is meditation." - Napoleon I

Re: WMI Connection to Remote PC with ManegementScope too slow(8-10 seconds). The WMI Query itself is OK (under 1 second)

OriginalGriff26-Dec-21 3:25

OriginalGriff

26-Dec-21 3:25

"Once and Future Computing" again? Laugh | :laugh:

"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
"Common sense is so rare these days, it should be classified as a super power" - Random T-shirt
AntiTwitter: @DalekDave is now a follower!

Re: WMI Connection to Remote PC with ManegementScope too slow(8-10 seconds). The WMI Query itself is OK (under 1 second)

Mustafa Levrek26-Dec-21 3:36

Mustafa Levrek

26-Dec-21 3:36

Hi, thanks for answer

Yes, i am doing actualy as you suggest. But the problem is, if i want to make WMI connections to several remote PCs, just the connection taking 10 seconds. Is it really not possible to shorten it?

Re: WMI Connection to Remote PC with ManegementScope too slow(8-10 seconds). The WMI Query itself is OK (under 1 second)

Dave Kreskowiak26-Dec-21 5:42

Dave Kreskowiak

26-Dec-21 5:42

Nope. There's no way to speed that up.

Asking questions is a skill
CodeProject Forum Guidelines
Google: C# How to debug code
Seriously, go read these articles.

Dave Kreskowiak

newbie using a game to learn c# and object-oriented programming Could I make an abstract factory to merge the other factories in a game?

biull smith21-Dec-21 3:23

biull smith

21-Dec-21 3:23

Sorry if this is the wrong place to ask or post is too long. I've studied examples and read up on factory design, factory pattern, abstract factory, & factory method; I followed a tutorial for a c# wpf rpg game that works well. But I'd like to enhance and expand on it so that I can understand the fundamentals of c# and object-oriented programming. There are seven factories in the game, for example. The factories I have in-game are an item factory, a Quest factory, a recipe factory, a monster factory, a spell factory, a trader factory, and a world factory. Is it possible to implement an abstract factory that combines all the factories? Would keeping them separate be best? Thank you for any assistance you may provide as well as any feedback you provide to.

here are the factories.

Itemfactory.cs   

   using System.Collections.Generic;
   using System.IO;
   using System.Linq;
   using System.Xml;
   using Engine.Actions;
   using Engine.Models;
   using Engine.Shared;
   using SOSCSRPG.Core;

   namespace Engine.Factories
  {
    public static class ItemFactory
    {
        private const string GAME_DATA_FILENAME = 
        ".\\GameData\\GameItems.xml";

        private static readonly List<GameItem> _standardGameItems = new 
        List<GameItem> 
        ();

        static ItemFactory()
        {
            if(File.Exists(GAME_DATA_FILENAME))
            {
                XmlDocument data = new XmlDocument();
                data.LoadXml(File.ReadAllText(GAME_DATA_FILENAME));

                LoadItemsFromNodes(data.SelectNodes("/GameItems/Weapons/Weapon"));
                
LoadItemsFromNodes(data.SelectNodes("/GameItems/HealingItems/HealingItem"));
                
LoadItemsFromNodes(data.SelectNodes("/GameItems/MiscellaneousItems/MiscellaneousItem"));
            }
            else
            {
                throw new FileNotFoundException($"Missing data file: 
                {GAME_DATA_FILENAME}");
            }
        }

        public static GameItem CreateGameItem(int itemTypeID)
        {
            return _standardGameItems.FirstOrDefault(item => 
            item.ItemTypeID == 
            itemTypeID)?.Clone();
        }

        private static void LoadItemsFromNodes(XmlNodeList nodes)
        {
            if(nodes == null)
            {
                return;
            }

            foreach(XmlNode node in nodes)
            {
                GameItem.ItemCategory itemCategory = 
                DetermineItemCategory(node.Name);
                
                GameItem gameItem =
                    new GameItem(itemCategory,
                                 node.AttributeAsInt("ID"),
                                 node.AttributeAsString("Name"),
                                 node.AttributeAsInt("Price"),
                                 itemCategory == 
                                 GameItem.ItemCategory.Weapon);

                if(itemCategory == GameItem.ItemCategory.Weapon)
                {
                    gameItem.Action =
                        new AttackWithWeapon(gameItem, 
                        node.AttributeAsString("DamageDice"));
                }
                else if(itemCategory == 
                GameItem.ItemCategory.Consumable)
                {
                    gameItem.Action =
                        new Heal(gameItem,
                                 
                        node.AttributeAsInt("HitPointsToHeal"));
                }

                _standardGameItems.Add(gameItem);
            }
        }

        private static GameItem.ItemCategory 
        DetermineItemCategory(string itemType)
        {
            switch(itemType)
            {
                case "Weapon":
                    return GameItem.ItemCategory.Weapon;
                case "HealingItem":
                    return GameItem.ItemCategory.Consumable;
                default:
                    return GameItem.ItemCategory.Miscellaneous;
            }
        }
    }
}


MonsterFactory.cs

    using System;
    using System.Collections.Generic;
    using System.IO;
    using System.Linq;
    using System.Xml;
    using Engine.Models;
    using Engine.Services;
    using Engine.Shared;
    using SOSCSRPG.Core;

    namespace Engine.Factories
    {
        public static class MonsterFactory
        {
            private const string GAME_DATA_FILENAME = 
            ".\\GameData\\Monsters.xml";

            private static readonly GameDetails s_gameDetails;
            private static readonly List<Monster> s_baseMonsters = new 
            List<Monster>();

            static MonsterFactory()
            {
                if(File.Exists(GAME_DATA_FILENAME))
                {
                    s_gameDetails = 
                    GameDetailsService.ReadGameDetails();
                
                    XmlDocument data = new XmlDocument();
                    data.LoadXml(File.ReadAllText(GAME_DATA_FILENAME));

                    string rootImagePath =
                    data.SelectSingleNode("/Monsters")
                   .AttributeAsString("RootImagePath");

                    LoadMonstersFromNodes(data.SelectNodes("/Monsters/Monster"), 
                    rootImagePath);
                    }
                    else
                    {
                        throw new FileNotFoundException($"Missing data 
                        file: 
                        {GAME_DATA_FILENAME}");
                    }
                }

                public static Monster GetMonsterFromLocation(Location 
                location)
               {
                    if (!location.MonstersHere.Any())
                    {
                        return null;
                    }

                    // Total the percentages of all monsters at this 
                       location.
                    int totalChances = location.MonstersHere.Sum(m => 
                    m.ChanceOfEncountering);

                   // Select a random number between 1 and the total 
                      (in case the total 
                  chances is not 100).
                  int randomNumber = 
                  DiceService.Instance.Roll(totalChances, 1).Value;

                 // Loop through the monster list, 
                 // adding the monster's percentage chance of appearing 
                    to the 
                    runningTotal 
                    variable.
               // When the random number is lower than the 
                 runningTotal,
              // that is the monster to return.
             int runningTotal = 0;

            foreach (MonsterEncounter monsterEncounter in 
            location.MonstersHere)
            {
                runningTotal += monsterEncounter.ChanceOfEncountering;

                if (randomNumber <= runningTotal)
                {
                    return GetMonster(monsterEncounter.MonsterID);
                }
            }

            // If there was a problem, return the last monster in the 
               list.
            return GetMonster(location.MonstersHere.Last().MonsterID);
        }

        private static void LoadMonstersFromNodes(XmlNodeList nodes, 
        string 
        rootImagePath)
        {
            if(nodes == null)
            {
                return;
            }

            foreach(XmlNode node in nodes)
            {
                var attributes = s_gameDetails.PlayerAttributes;

                attributes.First(a => a.Key.Equals("DEX")).BaseValue =
                    Convert.ToInt32(node.SelectSingleNode("./Dexterity").InnerText);
                attributes.First(a => 
                a.Key.Equals("DEX")).ModifiedValue =
                    Convert.ToInt32(node.SelectSingleNode("./Dexterity").InnerText);
                
                Monster monster =
                    new Monster(node.AttributeAsInt("ID"),
                                node.AttributeAsString("Name"),
                                $".{rootImagePath} 
                                {node.AttributeAsString("ImageName")}",
                                
                               node.AttributeAsInt("MaximumHitPoints"),
                                attributes,
                                ItemFactory.CreateGameItem(node.AttributeAsInt("WeaponID")),
                                node.AttributeAsInt("RewardXP"),
                                node.AttributeAsInt("Gold"));

                XmlNodeList lootItemNodes = 
                node.SelectNodes("./LootItems/LootItem");
                
                if(lootItemNodes != null)
                {
                    foreach(XmlNode lootItemNode in lootItemNodes)
                    {
                        monster.AddItemToLootTable(lootItemNode.AttributeAsInt("ID"),
                                                   
                        lootItemNode.AttributeAsInt("Percentage"));
                    }
                }

                s_baseMonsters.Add(monster);
            }
        }

        private static Monster GetMonster(int id)
        {
            Monster newMonster = s_baseMonsters.FirstOrDefault(m => 
            m.ID == 
            id).Clone();

            foreach (ItemPercentage itemPercentage in 
            newMonster.LootTable)
            {
                // Populate the new monster's inventory, using the loot 
                   table
                if (DiceService.Instance.Roll(100).Value <= 
                    itemPercentage.Percentage)
                {
                    newMonster.AddItemToInventory(ItemFactory.CreateGameItem(itemPercentage.ID));
                }
            }

            return newMonster;
        }
    }
}

QuestFactory.cs


    using System.Collections.Generic;
    using System.IO;
    using System.Linq;
    using System.Xml;
    using Engine.Models;
    using Engine.Shared;

    namespace Engine.Factories
    {
        internal static class QuestFactory
        {
            private const string GAME_DATA_FILENAME = 
            ".\\GameData\\Quests.xml";

            private static readonly List<Quest> _quests = new 
            List<Quest>();

        static QuestFactory()
        {
            if(File.Exists(GAME_DATA_FILENAME))
            {
                XmlDocument data = new XmlDocument();
                data.LoadXml(File.ReadAllText(GAME_DATA_FILENAME));

                LoadQuestsFromNodes(data.SelectNodes("/Quests/Quest"));
            }
            else
            {
                throw new FileNotFoundException($"Missing data file: 
                {GAME_DATA_FILENAME}");
            }
        }

        private static void LoadQuestsFromNodes(XmlNodeList nodes)
        {
            foreach(XmlNode node in nodes)
            {
                // Declare the items need to complete the quest, and 
                   its reward items
                List<ItemQuantity> itemsToComplete = new 
                List<ItemQuantity>();
                List<ItemQuantity> rewardItems = new List<ItemQuantity> 
                ();

                foreach(XmlNode childNode in 
                node.SelectNodes("./ItemsToComplete/Item"))
                {
                    GameItem item = ItemFactory.CreateGameItem(childNode.AttributeAsInt("ID"));

                    itemsToComplete.Add(new ItemQuantity(item, 
                    childNode.AttributeAsInt("Quantity")));
                }

                foreach(XmlNode childNode in 
                node.SelectNodes("./RewardItems/Item"))
                {
                    GameItem item = ItemFactory.CreateGameItem(childNode.AttributeAsInt("ID"));

                    rewardItems.Add(new ItemQuantity(item, 
                    childNode.AttributeAsInt("Quantity")));
                }

                _quests.Add(new Quest(node.AttributeAsInt("ID"),
                                      
                node.SelectSingleNode("./Name")?.InnerText ?? "",
                                      
                node.SelectSingleNode("./Description")?.InnerText 
                                      ?? "",
                                      itemsToComplete,
                                      
                         node.AttributeAsInt("RewardExperiencePoints"),
                                      
                         node.AttributeAsInt("RewardGold"),
                                      rewardItems));
            }
        }

        internal static Quest GetQuestByID(int id)
        {
            return _quests.FirstOrDefault(quest => quest.ID == id);
        }
    }
}


RecipeFactory.cs

    using System.Collections.Generic;
    using System.IO;
    using System.Linq;
    using System.Xml;
    using Engine.Models;
    using Engine.Shared;

    namespace Engine.Factories
   {
    public static class RecipeFactory
    {
        private const string GAME_DATA_FILENAME = 
        ".\\GameData\\Recipes.xml";

        private static readonly List<Recipe> _recipes = new 
        List<Recipe>();

        static RecipeFactory()
        {
            if(File.Exists(GAME_DATA_FILENAME))
            {
                XmlDocument data = new XmlDocument();
                data.LoadXml(File.ReadAllText(GAME_DATA_FILENAME));

                LoadRecipesFromNodes(data.SelectNodes("/Recipes/Recipe"));
            }
            else
            {
                throw new FileNotFoundException($"Missing data file: 
                {GAME_DATA_FILENAME}");
            }
        }

        private static void LoadRecipesFromNodes(XmlNodeList nodes)
        {
            foreach(XmlNode node in nodes)
            {
                var ingredients = new List<ItemQuantity>();

                foreach(XmlNode childNode in 
                node.SelectNodes("./Ingredients/Item"))
                {
                    GameItem item = ItemFactory.CreateGameItem(childNode.AttributeAsInt("ID"));

                    ingredients.Add(new ItemQuantity(item, 
                    childNode.AttributeAsInt("Quantity")));
                }

                var outputItems = new List<ItemQuantity>();

                foreach (XmlNode childNode in 
                node.SelectNodes("./OutputItems/Item"))
                {
                    GameItem item = ItemFactory.CreateGameItem(childNode.AttributeAsInt("ID"));

                    outputItems.Add(new ItemQuantity(item, 
                    childNode.AttributeAsInt("Quantity")));
                }

                Recipe recipe =
                    new Recipe(node.AttributeAsInt("ID"),
                        node.SelectSingleNode("./Name")?.InnerText ?? 
                        "",
                        ingredients, outputItems);

                _recipes.Add(recipe);
            }
        }

        public static Recipe RecipeByID(int id)
        {
            return _recipes.FirstOrDefault(x => x.ID == id);
        }
    }
}


Traderfactory.cs


    using System.Collections.Generic;
    using System.IO;
    using System.Linq;
    using System.Xml;
    using Engine.Models;
    using Engine.Shared;

    namespace Engine.Factories
    {
        public static class TraderFactory
        {
            private const string GAME_DATA_FILENAME = 
            ".\\GameData\\Traders.xml";

            private static readonly List<Trader> _traders = new 
            List<Trader>();

            static TraderFactory()
        {
            if(File.Exists(GAME_DATA_FILENAME))
            {
                XmlDocument data = new XmlDocument();
                data.LoadXml(File.ReadAllText(GAME_DATA_FILENAME));

                LoadTradersFromNodes(data.SelectNodes("/Traders/Trader"));
            }
            else
            {
                throw new FileNotFoundException($"Missing data file: 
                {GAME_DATA_FILENAME}");
            }
        }

        private static void LoadTradersFromNodes(XmlNodeList nodes)
        {
            foreach(XmlNode node in nodes)
            {
                Trader trader =
                    new Trader(node.AttributeAsInt("ID"),
                               
                    node.SelectSingleNode("./Name")?.InnerText ?? "");

                foreach(XmlNode childNode in 
                node.SelectNodes("./InventoryItems/Item"))
                {
                    int quantity = 
                    childNode.AttributeAsInt("Quantity");

                    // Create a new GameItem object for each item we 
                       add.
                    // This is to allow for unique items, like swords 
                       with 
                       enchantments.
                    for(int i = 0; i < quantity; i++)
                    {
                        trader.AddItemToInventory(ItemFactory.CreateGameItem(childNode.AttributeAsInt("ID")));
                    }
                }

                _traders.Add(trader);
            }
        }

        public static Trader GetTraderByID(int id)
        {
            return _traders.FirstOrDefault(t => t.ID == id);
        }
    }
}


WorldFactory.cs


    using System.IO;
    using System.Xml;
    using Engine.Models;
    using Engine.Shared;

    namespace Engine.Factories
    {
        internal static class WorldFactory
        {
            private const string GAME_DATA_FILENAME = 
            ".\\GameData\\Locations.xml";

            internal static World CreateWorld()
            {
                World world = new World();

                if(File.Exists(GAME_DATA_FILENAME))
                {
                    XmlDocument data = new XmlDocument();
                    data.LoadXml(File.ReadAllText(GAME_DATA_FILENAME));

                    string rootImagePath =
                    data.SelectSingleNode("/Locations")
                   .AttributeAsString("RootImagePath");

                LoadLocationsFromNodes(world, 
                rootImagePath, 
                data.SelectNodes("/Locations/Location"));
            }
            else
            {
                throw new FileNotFoundException($"Missing data file: 
                {GAME_DATA_FILENAME}");
            }

            return world;
        }

        private static void LoadLocationsFromNodes(World world, string 
        rootImagePath, 
        XmlNodeList nodes)
        {
            if(nodes == null)
            {
                return;
            }

            foreach(XmlNode node in nodes)
            {
                Location location =
                    new Location(node.AttributeAsInt("X"),
                                 node.AttributeAsInt("Y"),
                                 node.AttributeAsString("Name"),
                                 node.SelectSingleNode("./Description")?.InnerText ?? 
                                 "",
                                 $".{rootImagePath} 
                                 
                              {node.AttributeAsString("ImageName")}");

                AddMonsters(location, 
                node.SelectNodes("./Monsters/Monster"));
                AddQuests(location, 
                node.SelectNodes("./Quests/Quest"));
                AddTrader(location, node.SelectSingleNode("./Trader"));

                world.AddLocation(location);
            }
        }

        private static void AddMonsters(Location location, XmlNodeList 
        monsters)
        {
            if(monsters == null)
            {
                return;
            }

            foreach(XmlNode monsterNode in monsters)
            {
                location.AddMonster(monsterNode.AttributeAsInt("ID"),
                monsterNode.AttributeAsInt("Percent"));
            }
        }

        private static void AddQuests(Location location, XmlNodeList 
        quests)
        {
            if(quests == null)
            {
                return;
            }

            foreach(XmlNode questNode in quests)
            {
                location.QuestsAvailableHere
                        
               .Add(QuestFactory.GetQuestByID(questNode.AttributeAsInt("ID")));
            }
        }

        private static void AddTrader(Location location, XmlNode 
        traderHere)
        {
            if(traderHere == null)
            {
                return;
            }

            location.TraderHere =
            TraderFactory.GetTraderByID(traderHere.AttributeAsInt("ID"));
        }
    }
}


SpellFactory.cs


    using System;
    using System.Collections.Generic;
    using System.Linq;
    using System.Text;
    using System.Threading.Tasks;
    using Engine.Models;

    namespace Engine.Factories
    {
        public static class SpellFactory
        {
            private static readonly List<spells> _standardSpell = new 
            List<Spells> 
            ();

            static SpellFactory()
        {
            _standardSpell.Add(new Spell(8000, "Fireball", 5));
            _standardSpell.Add(new Spell(8001, "Lightning", 5));
            _standardSpell.Add(new Spell(8002, "Frost Bolt", 5));
        }

        public static Spell CreateSpell(int SpellID)
        {
            standardSpell = _standardSpell.FirstOrDefault(spell =>
            spell.SpellID == SpellID);

            if (standardSpell != null)
            {
                return standardSpell.Clone();
            }
            return null;
        }
    }
}

Re: newbie using a game to learn c# and object-oriented programming Could I make an abstract factory to merge the other factories in a game?

#realJSOP21-Dec-21 3:37

#realJSOP

21-Dec-21 3:37

I hate buzzwords, like "factory".

Define your entities, and your collections of entities, and then use xml serialization to populate them. You'll have a LOT less code to deal with.

I also suggest that you store your different entity types in their own xml files, because when you write new data, you have to write the entire file.

".45 ACP - because shooting twice is just silly" - JSOP, 2010
-----
You can never have too much ammo - unless you're swimming, or on fire. - JSOP, 2010
-----
When you pry the gun from my cold dead hands, be careful - the barrel will be very hot. - JSOP, 2013

Re: newbie using a game to learn c# and object-oriented programming Could I make an abstract factory to merge the other factories in a game?

biull smith21-Dec-21 4:04

biull smith

21-Dec-21 4:04

I've heard of xml the game actually uses xml files for some things. But how would you xml serialization?

Re: newbie using a game to learn c# and object-oriented programming Could I make an abstract factory to merge the other factories in a game?

Pete O'Hanlon21-Dec-21 5:06

Pete O'Hanlon

21-Dec-21 5:06

Examples of XML Serialization | Microsoft Docs[^]

Advanced TypeScript Programming Projects

Re: newbie using a game to learn c# and object-oriented programming Could I make an abstract factory to merge the other factories in a game?

biull smith21-Dec-21 5:17

biull smith

21-Dec-21 5:17

thanks for the links. I am new to c# and still learning the concepts of it. how would xml serialization help me? would it help me more than combining all factories into an abstract factory?

Re: newbie using a game to learn c# and object-oriented programming Could I make an abstract factory to merge the other factories in a game?

lmoelleb22-Dec-21 1:34

lmoelleb

22-Dec-21 1:34

When your game is running the data is all in memory of the computer. When your program stops this memory will be cleared. So if you wish to save the game, you need to store the state on disk. As disk files have a sequential list of bytes, we refer to the concept of converting your in memory data to a sequential sequence of data "serialization". Converting it back is "deserialization". XML is one of better known formats you can use to represent your data in a file. Another (probably more popular these days) is JSON - I would stick to one of these until you KNOW that another option is better. If you do not need to keep data after your program close (and maybe in the start you don't) you can simply skip this.

Your example code referring to this as a Factory is - a stretch. A factory is used when you need to create a new object - but you need some code that controls which object is created (so if you want to create a "Weapon" object, the Factory might have logic to figure out if it should create a Sword or a Gun object).

So the most important next step for you, is to stop referring to these as Factories. That will just confuse you (as here, you keep asking factory this, factory that - but you do not need a factory, nor do you have a factory)

In your example the XML is read "manually". What I mean with this, is there is code that look for certain named data in the XML file, and then place that into the memory object. The main advantage of this is: 1) Easy to debug, 2) Easy to deal with multiple formats - if you need to read old saved games for example. The disadvantage is a lot of code that takes time to write and maintain. Garry already provided links for the alternative approach, where you basically let the computer come up with an XML structure that match your data. If you do not want to convert data manually as done in your example, then that is how you would avoid all this code.

Re: newbie using a game to learn c# and object-oriented programming Could I make an abstract factory to merge the other factories in a game?

biull smith6-Jan-22 11:08

biull smith

6-Jan-22 11:08

I see thanks for the answer I've been looking at the links Garry posted to better understand XML serialization. So the item factory class etc are not factories nor do I have a factory, to begin with? sorry, the tutorial I'm following got a little confusing why I thought those classes were factories, but I see I was mistaken.

Re: newbie using a game to learn c# and object-oriented programming Could I make an abstract factory to merge the other factories in a game?

Gerry Schmitz21-Dec-21 7:30

Gerry Schmitz

21-Dec-21 7:30

They're not "factories"; they're deserializers. Maybe "data repositories".

I have two generic methods for XML serializing and deserializing any object. I sense you have a lot of duplicate code with "magic strings".

Re: newbie using a game to learn c# and object-oriented programming Could I make an abstract factory to merge the other factories in a game?

biull smith21-Dec-21 8:01

biull smith

21-Dec-21 8:01

what do you mean?

Re: newbie using a game to learn c# and object-oriented programming Could I make an abstract factory to merge the other factories in a game?

Gerry Schmitz21-Dec-21 8:22

Gerry Schmitz

21-Dec-21 8:22

"Factories" typically create "new" (empty) objects; you're simply restoring from existing data. Your static (data) collections constitute "data repositories".

So, calling your classes "factories" is a misnomer.

Re: newbie using a game to learn c# and object-oriented programming Could I make an abstract factory to merge the other factories in a game?

biull smith21-Dec-21 9:29

biull smith

21-Dec-21 9:29

I was mistaken. You are right; classes those are. I was just informed that by someone on another forum. Now I need to figure out if I want to go factory with them, then abstract factory, or XML serialization, like someone else suggested. Which one would be the better choice? I have seven so-called factories in the game/tutorial I've been following.

Re: newbie using a game to learn c# and object-oriented programming Could I make an abstract factory to merge the other factories in a game?

Gerry Schmitz21-Dec-21 11:04

Gerry Schmitz

21-Dec-21 11:04

I think you need a better handle on serializing a class. I think you have an opportunity to make your code more "generic" (which means fewer lines).

Examples of XML Serialization | Microsoft Docs

Generic Methods - C# Programming Guide | Microsoft Docs

Maybe your tutorial "started" with XML; in my case, for game tables, I typically build them in code as classes, and serialize / deserialize them to / from XML, if needed. Just find them easier to maintain and integrate that way; even for 100 entries or so. Stick everything in a "data class library".

modified 21-Dec-21 16:18pm.

Re: newbie using a game to learn c# and object-oriented programming Could I make an abstract factory to merge the other factories in a game?

biull smith21-Dec-21 14:15

biull smith

21-Dec-21 14:15

Would XML serialization be better for what I'm trying to do? Some of the factory classes will have a lot of subtypes in them, so wouldn't a factory or abstract factory be better? Let's say, for example. I took Itemfactory.cs, gameitem.cs, and Inventory.cs wouldn't those benefit from being a factory or even abstract factory?

itemfactory.cs

   using System.Collections.Generic;
   using System.IO;
   using System.Linq;
   using System.Xml;
   using Engine.Actions;
   using Engine.Models;
   using Engine.Shared;
   using SOSCSRPG.Core;

   namespace Engine.Factories
  {
    public static class ItemFactory
    {
        private const string GAME_DATA_FILENAME = 
        ".\\GameData\\GameItems.xml";

        private static readonly List<GameItem> _standardGameItems = new 
        List<GameItem> 
        ();

        static ItemFactory()
        {
            if(File.Exists(GAME_DATA_FILENAME))
            {
                XmlDocument data = new XmlDocument();
                data.LoadXml(File.ReadAllText(GAME_DATA_FILENAME));

                LoadItemsFromNodes(data.SelectNodes("/GameItems/Weapons/Weapon"));
                
LoadItemsFromNodes(data.SelectNodes("/GameItems/HealingItems/HealingItem"));
                
LoadItemsFromNodes(data.SelectNodes("/GameItems/MiscellaneousItems/MiscellaneousItem"));
            }
            else
            {
                throw new FileNotFoundException($"Missing data file: 
                {GAME_DATA_FILENAME}");
            }
        }

        public static GameItem CreateGameItem(int itemTypeID)
        {
            return _standardGameItems.FirstOrDefault(item => 
            item.ItemTypeID == 
            itemTypeID)?.Clone();
        }

        private static void LoadItemsFromNodes(XmlNodeList nodes)
        {
            if(nodes == null)
            {
                return;
            }

            foreach(XmlNode node in nodes)
            {
                GameItem.ItemCategory itemCategory = 
                DetermineItemCategory(node.Name);
                
                GameItem gameItem =
                    new GameItem(itemCategory,
                                 node.AttributeAsInt("ID"),
                                 node.AttributeAsString("Name"),
                                 node.AttributeAsInt("Price"),
                                 itemCategory == 
                                 GameItem.ItemCategory.Weapon);

                if(itemCategory == GameItem.ItemCategory.Weapon)
                {
                    gameItem.Action =
                        new AttackWithWeapon(gameItem, 
                        node.AttributeAsString("DamageDice"));
                }
                else if(itemCategory == 
                GameItem.ItemCategory.Consumable)
                {
                    gameItem.Action =
                        new Heal(gameItem,
                                 
                        node.AttributeAsInt("HitPointsToHeal"));
                }

                _standardGameItems.Add(gameItem);
            }
        }

        private static GameItem.ItemCategory 
        DetermineItemCategory(string itemType)
        {
            switch(itemType)
            {
                case "Weapon":
                    return GameItem.ItemCategory.Weapon;
                case "HealingItem":
                    return GameItem.ItemCategory.Consumable;
                default:
                    return GameItem.ItemCategory.Miscellaneous;
            }
        }
    }
}

gameitem.cs

using Engine.Actions;
using Newtonsoft.Json;

namespace Engine.Models
{
    public class GameItem
    {
        public enum ItemCategory
        {
            Miscellaneous,
            Weapon,
            Consumable
        }

        [JsonIgnore]
        public ItemCategory Category { get; }
        public int ItemTypeID { get; }
        [JsonIgnore]
        public string Name { get; }
        [JsonIgnore]
        public int Price { get; }
        [JsonIgnore]
        public bool IsUnique { get; }
        [JsonIgnore]
        public IAction Action { get; set; }

        public GameItem(ItemCategory category, int itemTypeID, string name, int price,
                        bool isUnique = false, IAction action = null)
        {
            Category = category;
            ItemTypeID = itemTypeID;
            Name = name;
            Price = price;
            IsUnique = isUnique;
            Action = action;
        }

        public void PerformAction(LivingEntity actor, LivingEntity target)
        {
            Action?.Execute(actor, target);
        }

        public GameItem Clone()
        {
            return new GameItem(Category, ItemTypeID, Name, Price, IsUnique, Action);
        }
    }
}

Inventory.cs

using System.Collections.Generic;
using System.Linq;
using Engine.Shared;
using Newtonsoft.Json;

namespace Engine.Models
{
    public class Inventory
    {
        #region Backing variables

        private readonly List<GameItem> _backingInventory =
            new List<GameItem>();

        private readonly List<GroupedInventoryItem> _backingGroupedInventoryItems =
            new List<GroupedInventoryItem>();

        #endregion

        #region Properties

        public IReadOnlyList<GameItem> Items => _backingInventory.AsReadOnly();

        [JsonIgnore]
        public IReadOnlyList<GroupedInventoryItem> GroupedInventory =>
            _backingGroupedInventoryItems.AsReadOnly();

        [JsonIgnore]
        public IReadOnlyList<GameItem> Weapons =>
            _backingInventory.ItemsThatAre(GameItem.ItemCategory.Weapon).AsReadOnly();

        [JsonIgnore]
        public IReadOnlyList<GameItem> Consumables =>
            _backingInventory.ItemsThatAre(GameItem.ItemCategory.Consumable).AsReadOnly();

        [JsonIgnore]
        public bool HasConsumable => Consumables.Any();

        #endregion

        #region Constructors

        public Inventory(IEnumerable<GameItem> items = null)
        {
            if(items == null)
            {
                return;
            }

            foreach(GameItem item in items)
            {
                _backingInventory.Add(item);

                AddItemToGroupedInventory(item);
            }
        }

        #endregion

        #region Public functions

        public bool HasAllTheseItems(IEnumerable<ItemQuantity> items)
        {
            return items.All(item => Items.Count(i => i.ItemTypeID == item.ItemID) >= item.Quantity);
        }

        public Inventory AddItem(GameItem item)
        {
            return AddItems(new List<GameItem> { item });
        }

        public Inventory AddItems(IEnumerable<GameItem> items)
        {
            return new Inventory(Items.Concat(items));
        }

        public Inventory RemoveItem(GameItem item)
        {
            return RemoveItems(new List<GameItem> { item });
        }

        public Inventory RemoveItems(IEnumerable<GameItem> items)
        {
            // REFACTOR: Look for a cleaner solution, with fewer temporary variables.
            List<GameItem> workingInventory = Items.ToList();
            IEnumerable<GameItem> itemsToRemove = items.ToList();

            foreach (GameItem item in itemsToRemove)
            {
                workingInventory.Remove(item);
            }

            return new Inventory(workingInventory);
        }

        public Inventory RemoveItems(IEnumerable<ItemQuantity> itemQuantities)
        {
            // REFACTOR
            Inventory workingInventory = new Inventory(Items);

            foreach (ItemQuantity itemQuantity in itemQuantities)
            {
                for (int i = 0; i < itemQuantity.Quantity; i++)
                {
                    workingInventory =
                        workingInventory
                            .RemoveItem(workingInventory
                                .Items
                                .First(item => item.ItemTypeID == itemQuantity.ItemID));
                }
            }

            return workingInventory;
        }

        #endregion

        #region Private functions

        // REFACTOR: Look for a better way to do this (extension method?)
        private void AddItemToGroupedInventory(GameItem item)
        {
            if(item.IsUnique)
            {
                _backingGroupedInventoryItems.Add(new GroupedInventoryItem(item, 1));
            }
            else
            {
                if(_backingGroupedInventoryItems.All(gi => gi.Item.ItemTypeID != item.ItemTypeID))
                {
                    _backingGroupedInventoryItems.Add(new GroupedInventoryItem(item, 0));
                }

                _backingGroupedInventoryItems.First(gi => gi.Item.ItemTypeID == 
                 item.ItemTypeID).Quantity++;
            }
        }

        #endregion
    }
}

modified 21-Dec-21 19:30pm.

Re: newbie using a game to learn c# and object-oriented programming Could I make an abstract factory to merge the other factories in a game?

Gerry Schmitz21-Dec-21 18:56

Gerry Schmitz

21-Dec-21 18:56

Me telling you to use XML serializing (or not) will do you no good until you understand the process better; that's what the links are for; including any links in the article.

One typically "saves" (things like inventory) when you expect to quit and restart a game (restore); that's a valid context for serialization. The rest is up to you.

Re: newbie using a game to learn c# and object-oriented programming Could I make an abstract factory to merge the other factories in a game?

biull smith6-Jan-22 11:18

biull smith

6-Jan-22 11:18

i see i will look in to that i've been reading up on the links trying to get a better understanding

Total Newbie... just installing Visual Studio...

Audio Babble17-Dec-21 7:08

Audio Babble

17-Dec-21 7:08

Hey all,

I am currently downloading files for .net desktop development workload.

Just wondering - is there any way to retrieve the installer files for offline installation should I need it in the future?

Cheers Smile | :)

Re: Total Newbie... just installing Visual Studio...

OriginalGriff17-Dec-21 7:12

OriginalGriff

17-Dec-21 7:12

What, you think MS is going to go bust and Visual Studio will disappear overnight?

See here: Create an offline installation - Visual Studio (Windows) | Microsoft Docs[^]

BTW: you need to learn to google first - it took me less than 10 seconds to find that starting with a "Visual Studio ISO" search and following a link from a result link ... You will save a lot of time if you get used to researching with it first!

Re: Total Newbie... just installing Visual Studio...

Audio Babble17-Dec-21 7:24

Audio Babble

17-Dec-21 7:24

Thanks... haha - no I'm planning an OS re-install soon so was trying to save myself the time downloading again.

Yes I did go and search it out beforehand - unfortunately, I chose the option to Download AND install rather than Download THEN install.

Should have made the question clearer, was trying to find out if there is a way to retrieve the install files from temp... but no worries, I reckon it would be a massive hassle even if there was a way - I'll just make sure I choose the right option next time!

Cheers Smile | :)

Displaying data in a textBox

Luis M. Rojas16-Dec-21 9:50

Luis M. Rojas

16-Dec-21 9:50

I have a textBox , when the user click on the button i read a table and make a foreach to read the rows and then display the data in the textbox.
The data in the txtMensaje has to display and change until the end, but only the last row is display.
Ex. if i have; data1, data2.data3....n
the first display data in the textbox should be data1, then data2 has to be display and so on.
But nothing happen

int fila = TNombre.Rows.Count;
     if (fila > 0)
     {
         foreach (DataRow row in TNombre.Rows)
          {               
            txtMensaje.Text = row[0].ToString();                                              
         }
     }

Thanks

Re: Displaying data in a textBox

trønderen16-Dec-21 10:10

trønderen

16-Dec-21 10:10

Try to do the same with a plain string variable, rather than txtMensaje.Text!

On each iteration, the string value is replaced. The last assignment applies.

If you want to append the lines, one after one other, you use +=, rather than = (regardless of whether you are appending to a plain string or the contents of a text box).

Re: Displaying data in a textBox

OriginalGriff16-Dec-21 10:50

OriginalGriff

16-Dec-21 10:50

You can't use a loop for that: when an event is raised your handler is called and nothing else happens until your event handler hits the return statement (or the end of the method) - and that very much include display updates!

So reading the lines in a loop does nothing useful, because the Paint event isn't actioned until after the last line has been displayed - so the only thing your user will ever see is the last line!

If you want to do that, you will need to set up a Timer (with an Interval that says how long you want each line displayed for) and kick it off in your button Click event.
Inside the Timer.Tick handler, copy just one line to the textbox, and set up for the next by moving an index on one. Then exit (remembering to cancel the timer when you run out of lines).

Last Visit: 31-Dec-99 19:00 Last Update: 8-Dec-23 16:19

Refresh

ᐊ Prev 1...79 80 81 828384 85 86 87 88 Next ᐅ

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.