C / C++ / MFC

29-Aug-22 5:19

I am dealing with a school exercise in c++ within an Ubuntu virtual machine. I have a header.h with the class, a header.cpp with the method implementation, a main.cpp and i compile it (main.cpp includes header.cpp which includes header.h) with the following: g++ main.cpp -Wall -o main (from ubuntu terminal). Then I run it and that's ok.
I then tried to import the same exercise in visual studio 2019 creating at first an empty c++ project. After I tried with a CMake project. In both cases compiler/linker return error LNK2005 relevant to all the method implementation saying that they are already defined in main.cpp.obj.
I would attach the complete project in both versions (Ubuntu side and vstudio19 side) but I do not see how. Regards

k505429-Aug-22 5:35

k5054

29-Aug-22 5:35

Roberto64_Ge wrote:
main.cpp includes header.cpp which includes header.h

This is probably the source of your problem. Visual Studio is probably compiling header.cpp and creating a separate object file, then compiles main.cpp, which includes header.cpp, and so creates two copies of the methods defined in header.cpp. In general it is a mistake to #include a cpp file in another cpp file. You main.cpp only needs to include header.h, which should only provide a declaration of your class. You would then compile main.cpp and header.cpp separately.

You can do this on the ubuntu command line using

g++ -Wall -Wextra main.cpp header.cpp -o main

or alternatively

g++ -Wall -Wextra -c main.cpp
g++ -Wall -Wextra -c header.cpp
g++ main.o header.o -o main

In the above example, the -c option to g++ tells the compiler to only produce an intermediate object file (e.g. a .o file), and not try to produce an executable. The third line creates the final executable, and includes all the system libraries and startup code needed for the executable.

Keep Calm and Carry On

Roberto64_Ge29-Aug-22 6:03

29-Aug-22 6:03

Thank you, your answer is clear. Now the point is that I am not used at all in c++ compiling/linking and I am not used to VS configuration of compiler and linker, so I ask if you could help. Correct me if I am wrong : (we are within VS2019)
1) a create a new cc++ emty project
2) Add main.cpp , header.cpp and header.h to the project.
3) Include header.h in main.cpp
Now from the VS2019 environment, how do I compile separately main.cpp and header.cpp? I guess I have to compile header.cpp before. Isn't it? But how do I do that?
And then, how do I compile main.cpp and how the VS2019 knows, while compiling main.cpp, where to get the method implementation i.e. the header.obj?

k505429-Aug-22 6:09

k5054

29-Aug-22 6:09

If you've created a VS C++ project, it knows how to deal with files that you add to the project. All you should need to do for a simple project is hit Build, and the IDE will take care of the rest.

Keep Calm and Carry On

Roberto64_Ge29-Aug-22 6:13

29-Aug-22 6:13

Ok I tried and I did it. I right clicked on header.cpp and it gave the option to compile. This created the header.obj. Then I right clicked on the main.cpp and again I had the option to compile it and this generated the exe. Before doing all this I included in the main.cpp only header.h,
Now it works. Thanks for the clear explanation

k505429-Aug-22 6:28

k5054

29-Aug-22 6:28

That's one way to do it, but not the most efficient: Building and Cleaning Projects and Solutions - Visual Studio (Windows) | Microsoft Docs

Keep Calm and Carry On

Roberto64_Ge29-Aug-22 9:56

29-Aug-22 9:56

ok i will read it
Thumbs Up | :thumbsup:

Richard MacCutchan29-Aug-22 5:45

Richard MacCutchan

29-Aug-22 5:45

Roberto64_Ge wrote:
main.cpp includes header.cpp which includes header.h

This means that all the definitions in header.cpp will be duplicated in the object files. Do not include .cpp files in others, only include the actual headers, i.e. in this case main.cpp should only include header.h.

Roberto64_Ge29-Aug-22 6:14

tracking down linker errors

29-Aug-22 6:14

ok thanks

Calin Negru27-Aug-22 4:50

Calin Negru

27-Aug-22 4:50

I there a way to track down the linker errors further than what`s being offered in the "Build output" window?

Re: tracking down linker errors

Mircea Neacsu27-Aug-22 5:03

Mircea Neacsu

27-Aug-22 5:03

Not really. You can increase number of linker messages by changing the "Show Progress" option. The "Display all messages" is really verbose.

Otherwise, sometimes they can be tricky to trace. Just yesterday I had one where an include directive was used after a

C++

namespace blah_blah {

line. Linker was looking for a function definition inside the namespace when it was actually outside.

Mircea

Re: tracking down linker errors

Richard MacCutchan27-Aug-22 7:44

Richard MacCutchan

27-Aug-22 7:44

If you actually provide some details then maybe we can help.

[solved]Re: tracking down linker errors

Calin Negru27-Aug-22 9:01

Calin Negru

27-Aug-22 9:01

I`m not sure what details you are expecting. All I have in the build output window is a one line message:
1>Tutorial07.obj : error LNK2001: unresolved external symbol "void __cdecl CheckCollisions(class std::vector<class gameelement="" *,class="" std::allocator<class="" *=""> > *,int,class contim *,int)"

I know an error of this type means that some parameters don`t match in the function definition, declaration and the place where the function is being used. I did a search for the function name within the code file, everything seems to be fine in the function header (return type, function name and parameters) everywhere. I need more details to know what exactly doesn`t match.

void CheckCollisions(vector<gameelement * > * GAllElements, int UnitCount, contim* OldNewTable,int frame);

never mind I found the error, it was a parameter mismatch, you have to be extra careful with those.

modified 27-Aug-22 15:51pm.

Using nlohmann JSON to insert more data

Kiran Satish26-Aug-22 8:03

Kiran Satish

26-Aug-22 8:03

I have a json file genrated in python from another system that needs to be read/updated in another MFC application. I can successfully read the existing data from the json file using nlohmann json add-in. For example, the file consists of two data fields with one field having any array of two subfields as below

C++

{
  "city_data":[
     {
       "t":"m",
       "l":[12.0,10.3,0.0,1.0]
     },
     {
       "t":"l",
       "l":[10.1,20.37,0.0,1.0]
     },
     {
       "t":"l",
       "l":[47.82,4.63,0.0,1.0]
     },
     {
       "t":"m",
       "l":[67.66,43.33,0.0,1.0]
     }
   ],
   "map_data":"JZDKZTCaTyWQymUwmk8lkMplMJpPJZDKZTCaTyWQymUwmk/8/+n8AVAZ1WCxk8rYAAAAASUVORK5CYII="
}

The "map_data" is basically base64 encoded png image.
I would like to add more entries into "city_data" field as {"t":"x","l":[0.0,0.0,0.0,0.0]} while the "map_data" stays the same. Then I can write the json object into a new file with updates.

To read the json file,

C++

std::ifstream f(file);
json data = json::parse(f);

To retreive "city_data" and then its type and location

C++

json& cityInfo = data["city_data"];
for (unsigned int i = 0; i < cityInfo.size(); i++)
        {
            json& cityType = cityInfo[i];
            std::string ctyTyp = cityType["t"];
            json& cityLoc = cityType["l"];
            std::float_t x = cityLoc[0];
            std::float_t y = cityLoc[1];
            // do something with the retrieved values      
        }
//To retreive map data
ofstream outfile;
outfile.open(m_strFolderPath + m_strFileName + ".png", ofstream::binary);
std::string mapFrame = data["map_data"];
string temp = base64_decode(mapFrame );
outfile.write(temp.c_str(), temp.size());
outfile.close();
f.close();

Any suggestions on how to insert new city_data fields into the nlohmann JSON object? or a way to create a new json file like in above format?
thanks

PKNT

modified 26-Aug-22 14:17pm.

Re: Using nlohmann JSON to insert more data

Mircea Neacsu26-Aug-22 9:53

Mircea Neacsu

26-Aug-22 9:53

I haven't used nlohmann json in a while (because I've made my own - see mlib/json.h at master · neacsum/mlib · GitHub[^]

However I think this should work:

C++

// do something with the retrieved values
cityInfo[i]["newval"] = to_string (i + 1);

--EDIT--
I read your message again and realized you want to extend the cityInfo array. In this case you would simply write something like:

C++

cityInfo[4] = json::parse(R"({"t":"x", "l" : [0.0, 0.0, 0.0, 0.0] })");

Mircea

modified 26-Aug-22 21:09pm.

Question About CToolTipCtrl

ForNow24-Aug-22 9:33

ForNow

24-Aug-22 9:33

Hi
I have some question about the class. I would like to use it on My CRichEditctrl where the source code is for my debugger.

There are CWnd members in a number of the methods in the class would that in my case be the CrichEditCtrl in Addition the HiTest api which has a CPoint member is that point relative to (in my case) the CRichEditCtrl

Thanks

Victor Nijegorodov24-Aug-22 22:53

Victor Nijegorodov

24-Aug-22 22:53

Umm, could you formulate your question(s) a bit more clear?

ForNow24-Aug-22 23:19

ForNow

24-Aug-22 23:19

I’ll ask a more specific question the create api of the CtooltipCtrl class has 2 parameters CWnd and dwstyle

I would like to use it in my derived CrichEditctrl class whose parent is a CDialog should the Cwnd be the CRichEditrl or The CDialog

Thanks

Victor Nijegorodov25-Aug-22 0:56

Victor Nijegorodov

25-Aug-22 0:56

It depends upon what and how are you going to display tooltips for your control.
If it would be some text for the whole control then pass the CDialog CWnd* (in this case you will handle the TTN_NEEDTEXT notification in the dialog class).
If the tooltip text would depend on some position or some content within the controls then it could be better passing the control CWnd* (then you will handle the TTN_NEEDTEXT notification in the control's class).