Click here to Skip to main content
15,390,470 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
include "baglan.php";
if (isset($_POST["br"]) && isset($_POST["ad"]) && isset($_POST["yz"]) && isset($_POST["yv"]) && isset($_POST["ft"]) && isset($_POST["st"]) && isset($_POST["im"])) {
$br = $_POST["br"];
$ad = $_POST["ad"];
$yz = $_POST["yz"];
$yv = $_POST["yv"];
$ft = $_POST["ft"];
$st = $_POST["st"];
$im = $_POST["im"];






$sql = "INSERT INTO `kid`(`id`, `kimg`, `ad`, `yazar`, `yv`, `ft`, `stok` ) VALUES ('$br','$im','$ad','$yz','$yv','$ft'','$st')";


if ($conn->query($sql) === TRUE) {
echo "New record created successfully";
} else {
echo "Error:
" . $conn->error;
}
}

$conn->close();
?>

What I have tried:

$sql = "INSERT INTO `kid`(`id`, `kimg`, `ad`, `yazar`, `yv`, `ft`, `stok` ) VALUES ('$br','$im','$ad','$yz','$yv','$ft'','$st')";
Posted
Updated 22-Jun-22 9:24am

As a follow up to what 0x01AA has said, a even better solution is not to do that at all.
Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'
The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'
Which SQL sees as three separate commands:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';
A perfectly valid SELECT
SQL
DROP TABLE MyTable;
A perfectly valid "delete the table" command
SQL
--'
And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

And in a login system? That's just asking for trouble as I don't even have to have to register with you to do it!

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?
   
Check your sql carefully...
"INSERT INTO `kid`(`id`, `kimg`, `ad`, `yazar`, `yv`, `ft`, `stok` ) VALUES ('$br','$im','$ad','$yz','$yv','$ft'','$st')";


Focus on
'$ft'',
and here the
''

What I mean, it should be like this:
'$ft',
   
v3
Comments
0x01AA 22-Jun-22 15:19pm
   
Thank you very much. see you for the next typo ;)

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

  Print Answers RSS
Top Experts
Last 24hrsThis month


CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900